lkml.org 
[lkml]   [2017]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] init/main.c: check for null pointer before calling initcall
From
Date
On 10/27/2017 11:22 AM, Thomas Gleixner wrote:
> On Fri, 27 Oct 2017, David Daney wrote:
>
>> On 10/27/2017 09:47 AM, Abderrahmane Benbachir wrote:
>>> Simple check to prevent kernel panic when initcall does not exit
>>
>> Interesting, under what circumstances do you observe the panic?
>>
>> It would be best to include this information in the patch changelog.
>
> device_initcall(NULL);
>
> might do that, but then it rightfully crashes on boot.
>

That was kind of my point. The module loader case already checks for a
non-NULL pointer, and any NULLs in the in-kernel initializer tables
would indicate a bigger problem that should be fixed instead.

David Daney

\
 
 \ /
  Last update: 2017-10-28 20:19    [W:0.071 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site