lkml.org 
[lkml]   [2017]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/12] Input: ad7897 - use managed devm_device_add_group
Hi Dmitry,

> > Commit 57b8ff070f98 ("driver core: add devm_device_add_group()
> > and friends") has added the the managed version for creating
> > sysfs group files.
> >
> > Use devm_device_add_group instead of sysfs_create_group and
> > remove the relative sysfs_remove_group and goto label.
> >
> > CC: Michael Hennerich <michael.hennerich@analog.com>
> > Signed-off-by: Andi Shyti <andi@etezian.org>
> > ---
> > drivers/input/touchscreen/ad7877.c | 8 ++------
> > 1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c
> > index 9c250ae780d9..677ba38b4d1c 100644
> > --- a/drivers/input/touchscreen/ad7877.c
> > +++ b/drivers/input/touchscreen/ad7877.c
> > @@ -783,18 +783,16 @@ static int ad7877_probe(struct spi_device *spi)
> > goto err_free_mem;
> > }
> >
> > - err = sysfs_create_group(&spi->dev.kobj, &ad7877_attr_group);
> > + err = devm_device_add_group(&spi->dev, &ad7877_attr_group);
>
> This changes order of operations and ultimately may cause use-after-free
> as memory for ad7877 structure will be freed before we remove
> attributes.

yes, right... sorry... was too fast at making these patches :)
I'll send a second version over the weekend.

Andi

\
 
 \ /
  Last update: 2017-10-28 20:16    [W:0.039 / U:28.052 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site