Messages in this thread | | | From | "Dilger, Andreas" <> | Subject | Re: [PATCH 2/9] staging: lustre: ldlm: remove unused 'work_list' arg from ldlm_process_flock_lock() | Date | Fri, 27 Oct 2017 09:09:36 +0000 |
| |
On Oct 22, 2017, at 18:53, NeilBrown <neilb@suse.com> wrote: > > 'work_list' is only set to NULL, and is never used. > So discard it. > > Signed-off-by: NeilBrown <neilb@suse.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> --- > drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > index f719dc05e1ea..766653b4d8a5 100644 > --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > @@ -123,8 +123,7 @@ ldlm_flock_destroy(struct ldlm_lock *lock, enum ldlm_mode mode, __u64 flags) > * > */ > static int ldlm_process_flock_lock(struct ldlm_lock *req, __u64 *flags, > - enum ldlm_error *err, > - struct list_head *work_list) > + enum ldlm_error *err) > { > struct ldlm_resource *res = req->l_resource; > struct ldlm_namespace *ns = ldlm_res_to_ns(res); > @@ -594,7 +593,7 @@ ldlm_flock_completion_ast(struct ldlm_lock *lock, __u64 flags, void *data) > /* We need to reprocess the lock to do merges or splits > * with existing locks owned by this process. > */ > - ldlm_process_flock_lock(lock, &noreproc, &err, NULL); > + ldlm_process_flock_lock(lock, &noreproc, &err); > } > unlock_res_and_lock(lock); > return rc; > >
Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation
| |