lkml.org 
[lkml]   [2017]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 3/9] net: dsa: fix dsa_is_normal_port helper
From
Date
On 10/26/2017 08:22 AM, Vivien Didelot wrote:
> In order to know if a port is of type user, dsa_is_normal_port checks
> that the given port is not of type DSA nor CPU. This is not enough
> because a port can be unused.
>
> Without the previous fix, this caused the unused mv88e6xxx ports to be
> configured in normal mode.
>
> The ds->enabled_port_mask reports the user ports, so check this instead.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian

\
 
 \ /
  Last update: 2017-10-27 01:09    [W:0.090 / U:35.824 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site