lkml.org 
[lkml]   [2017]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] i2c: aspeed: Deassert reset in probe
> > +       bus->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
>
> This could return error values in case of broken device trees, so you
> may want to check IS_ERR(bus->rst) and handle the error here.
>
> > + reset_control_deassert(bus->rst);
>
> Otherwise this will dump a warning.
>
> > +
> > ret = of_property_read_u32(pdev->dev.of_node,
> > "bus-frequency", &bus->bus_frequency);
> > if (ret < 0) {
> > @@ -919,6 +925,8 @@ static int aspeed_i2c_remove_bus(struct platform_device *pdev)
> >
> > i2c_del_adapter(&bus->adap);
> >
> > + reset_control_assert(bus->rst);
>
> As will this.
>
> Reviewed-by: Philipp Zabel <philipp.zabel@gmail.com>

Joel, do you want to fix it? I'd think it makes sense...

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-10-26 22:54    [W:0.040 / U:0.188 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site