lkml.org 
[lkml]   [2017]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] iio/light/max44000: Use common error handling code in max44000_probe()
From
Date
>> @@ -596,6 +592,10 @@ static int max44000_probe(struct i2c_client *client,
>> }
>>
>> return iio_device_register(indio_dev);
>> +
>> +report_failure:
>> + dev_err(&client->dev, "failed to write init config: %d\n", ret);
> This reduces readability of the code for a very minor gain.

I got an other software development view on this aspect.


> Printing an error message is not a source of bugs

I find such a general information questionable.

It is also possible to discover various update candidates in this software area.


> or similar unlike unwinding some state, so a unified path makes little sense.

How does such a view fit to the section “7) Centralized exiting of functions”
in the document “coding-style.rst”?

Regards,
Markus

\
 
 \ /
  Last update: 2017-10-26 18:51    [W:0.038 / U:1.312 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site