lkml.org 
[lkml]   [2017]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 4/6] drm/rockchip/dsi: add dual mipi channel support
From
Date


On 10/25/2017 01:34 PM, Sean Paul wrote:
> On Wed, Oct 25, 2017 at 11:51:01AM +0800, Nickey Yang wrote:
>> This patch add dual mipi channel support:
>> 1.add definition of dsi1 register and grf operation.
>> 2.dsi0 and dsi1 will work in master and slave mode
>> when driving dual mipi panel.
>>
>> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
>> ---
>
> In the last revision, I asked you to provide changelog between revisions,
> *please* do this. You received review on the last version and a bunch of the
> feedback hasn't been taken into account with no explanation as to why. Please go
> back to the last version, read the reviews that people were generous enough to
> give and either fix the code or explain why you're not.
>
>> drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 377 ++++++++++++++++++++--------
>> drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 +
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 3 +
>> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 +
>> 5 files changed, 279 insertions(+), 105 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
>> index 589b420..25e7b77 100644
>> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
>> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
>
> <snip />
>
>> +static int rockchip_dsi_dual_channel_probe(struct dw_mipi_dsi *dsi)
>> +{
>> + struct device_node *np;
>> + struct platform_device *secondary;
>> +
>> + np = of_parse_phandle(dsi->dev->of_node, "rockchip,dual-channel", 0);
>> + if (np) {
>> + secondary = of_find_device_by_node(np);
>> + dsi->slave = platform_get_drvdata(secondary);
>> + of_node_put(np);
>> +
>> + if (!dsi->slave)
>> + return -EPROBE_DEFER;
>
> Archit asked you not to do this in the previous review.

I've replied with some more details to the patch which adds this in the DT
binding doc.

Thanks,
Archit

>
>> +
>> + dsi->slave->master = dsi;
>> + }
>> +
>> + return 0;
>> +}
>
> <snip />
>
>> --
>> 1.9.1
>>
>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

\
 
 \ /
  Last update: 2017-10-26 07:12    [W:0.067 / U:1.848 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site