lkml.org 
[lkml]   [2017]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG
Hi Herbert,

Quoting Herbert Xu <herbert@gondor.apana.org.au>:

> On Wed, Oct 25, 2017 at 07:38:35PM -0500, Gustavo A. R. Silva wrote:
>>
>> I don't think we want something like:
>>
>> bool err;
>>
>> err = build_spdinfo(r_skb, net, sportid, seq, *flags) < 0 ? true : false;
>> BUG_ON(err);
>
> How about
>
> int err;
>
> err = build_spdinfo(r_skb, net, sportid, seq, *flags);
> BUG_ON(err < 0);
>

I like it.

Thanks
--
Gustavo A. R. Silva




\
 
 \ /
  Last update: 2017-10-26 12:48    [W:0.067 / U:6.316 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site