lkml.org 
[lkml]   [2017]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: I2C-Octeon: Use common error handling code in octeon_i2c_probe()
From
Date
> NAK.  We don't need any more Markus Elfring spam.

Why do you not like another update suggestion for this use case?


>> Add a jump target so that a specific error message is stored only once
>> at the end of this function implementation.
>
> Please read C standard about duplicate literal strings to see
> why this is a completely misleading and false statement.

* I proposed to adjust the position for one function call, didn't I?

* Do you care for a bit of code reduction?

* Do you prefer to use an optimisation option like “-fmerge-constants”
(instead of integrating the shown small change)?

Regards,
Markus

\
 
 \ /
  Last update: 2017-10-26 07:01    [W:0.035 / U:31.488 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site