lkml.org 
[lkml]   [2017]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/9] usb: host: isp1362-hcd: mark expected switch fall-through
Greg,

Quoting "Gustavo A. R. Silva" <garsilva@embeddedor.com>:

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/usb/host/isp1362-hcd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/isp1362-hcd.c b/drivers/usb/host/isp1362-hcd.c
> index 9b7e307..753d576 100644
> --- a/drivers/usb/host/isp1362-hcd.c
> +++ b/drivers/usb/host/isp1362-hcd.c
> @@ -1578,6 +1578,7 @@ static int isp1362_hub_control(struct usb_hcd
> *hcd, u16 typeReq, u16 wValue,
> spin_lock_irqsave(&isp1362_hcd->lock, flags);
> isp1362_write_reg32(isp1362_hcd, HCRHSTATUS, RH_HS_OCIC);
> spin_unlock_irqrestore(&isp1362_hcd->lock, flags);
> + /* fall through */

I'm suspicious this should be a 'break' instead.

What do you think?

> case C_HUB_LOCAL_POWER:
> DBG(0, "C_HUB_LOCAL_POWER\n");
> break;
> --
> 2.7.4

Thanks
--
Gustavo A. R. Silva




\
 
 \ /
  Last update: 2017-10-25 21:05    [W:0.089 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site