Messages in this thread | | | From | PrasannaKumar Muralidharan <> | Date | Wed, 25 Oct 2017 20:55:33 +0530 | Subject | Re: [PATCH] tpm: Move Linux RNG connection to hwrng |
| |
Hi Jason,
On 25 October 2017 at 20:48, Jason Gunthorpe <jgunthorpe@obsidianresearch.com> wrote: > On Wed, Oct 25, 2017 at 08:15:09PM +0530, PrasannaKumar Muralidharan > wrote: > >> > +static int tpm_add_hwrng(struct tpm_chip *chip) >> > +{ >> > + if (!IS_ENABLED(CONFIG_HW_RANDOM_TPM)) >> > + return 0; >> >> Can #ifndef CONFIG_HW_RANDOM_TPM be used instead? That way an if >> condition can be avoided. > > Generally speaking IS_ENABLED is prefered over #ifdef as it reduces the > set of compilation combinations.
Oh okay. No issues then.
Regards, PrasannaKumar
| |