Messages in this thread | | | Subject | Re: [PATCH v5 2/6] perf record: Get the first sample time and last sample time | From | "Jin, Yao" <> | Date | Tue, 24 Oct 2017 15:29:46 +0800 |
| |
On 10/24/2017 3:16 PM, Jiri Olsa wrote: > On Tue, Oct 24, 2017 at 10:03:05AM +0800, Jin, Yao wrote: > > SNIP > >>> hum, could you still unset the sample if there's no time given? >>> and keep the speed in this case.. >>> >>> jirka >>> >> >> Hi Jiri, >> >> I check this question again. The '--time' option is for perf report but not >> for perf record. >> >> For perf record, we have to always walk on all samples to get the time of >> first sample and the time of last sample whatever buildid_all is enabled or >> not enabled. So 'rec->tool.sample = NULL' is removed. >> >> Sorry, the previous mail was replied at midnight, I was drowsy. :( >> >> If my answer is correct, I will not send v6. If my understanding is still >> not correct, please let me know. > > right, I did not realize we store this unconditionaly.. then yes, it's ok > > I think I've already acked this, anyway for the patchset: > > Acked-by: Jiri Olsa <jolsa@kernel.org> > > thanks, > jirka >
Hi Jiri,
Thanks a lot for your review comments and your helps!
Thanks Jin Yao
| |