lkml.org 
[lkml]   [2017]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] tpm: Move Linux RNG connection to hwrng
    On Tue, Oct 24, 2017 at 03:34:49PM -0600, Jason Gunthorpe wrote:
    > On Tue, Oct 24, 2017 at 12:42:35PM -0600, Jason Gunthorpe wrote:
    >
    > > This is compile tested only.
    >
    > 0day says the kconfig has a problem when randomized, here is the fix I
    > will roll into a v2 in a few days:

    I will probably have to postpone the review to next week anyway so take
    your time :-)

    /Jarkko

    >
    > diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
    > index a95725fa77789e..ca89da3e4b2ae9 100644
    > --- a/drivers/char/tpm/Kconfig
    > +++ b/drivers/char/tpm/Kconfig
    > @@ -27,16 +27,13 @@ menuconfig TCG_TPM
    > if TCG_TPM
    >
    > config HW_RANDOM_TPM
    > - tristate "TPM HW Random Number Generator support"
    > - depends on TCG_TPM && HW_RANDOM
    > - default HW_RANDOM
    > + bool "TPM HW Random Number Generator support"
    > + depends on TCG_TPM && HW_RANDOM && !(TCG_TPM=y && HW_RANDOM=m)
    > + default y
    > ---help---
    > This driver provides kernel-side support for the Random Number
    > Generator in the Trusted Platform Module
    >
    > - To compile this driver as a module, choose M here: the
    > - module will be called tpm-rng.
    > -
    > If unsure, say Y.
    >
    > config TCG_TIS_CORE

    \
     
     \ /
      Last update: 2017-10-25 00:30    [W:2.394 / U:0.664 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site