lkml.org 
[lkml]   [2017]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH net-next 0/2] net: dsa: don't unmask port bitmaps
Date
DSA has several bitmaps to store the type of ports: cpu_port_mask,
dsa_port_mask and enabled_port_mask. But the code is inconsistently
unmasking them.

The legacy code tries to unmask cpu_port_mask and dsa_port_mask but
skips enabled_port_mask.

The new bindings unmasks cpu_port_mask and enabled_port_mask but skips
dsa_port_mask.

In fact there is no need to unmask them because we are in the error
path, and they won't be used after. Instead of fixing the unmasking,
simply remove them.

Vivien Didelot (2):
net: dsa: legacy: don't unmask port bitmaps
net: dsa: don't unmask port bitmaps

net/dsa/dsa2.c | 4 ----
net/dsa/legacy.c | 4 ----
2 files changed, 8 deletions(-)

--
2.14.2

\
 
 \ /
  Last update: 2017-10-23 20:18    [W:0.120 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site