lkml.org 
[lkml]   [2017]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/14] soundwire: Add MIPI DisCo property helpers
On Thu, Oct 19, 2017 at 08:33:20AM +0530, Vinod Koul wrote:

> + /* device is probed so let's read the properties now */
> + if (slave->ops && slave->ops->read_prop)
> + slave->ops->read_prop(slave);

Is it valid for us to not be able to read the properties?

> + fwnode_property_read_u32(node, "mipi-sdw-port-max-wordlength",
> + &dpn[i].max_word);
> + fwnode_property_read_u32(node, "mipi-sdw-port-min-wordlength",
> + &dpn[i].min_word);

Don't we know this stuff simply by virtue of knowing what device we're
talking to (given that there aren't class devices)?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-10-22 17:49    [W:0.438 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site