lkml.org 
[lkml]   [2017]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: crypto-testmgr: Use common error handling code in drbg_cavs_test()
From
Date
> Though, jumping back and forth like this with goto directives is something 
> that looks a bit strange. At least to my taste, may I suggest to have gotos
> pointing only downwards and not up again? (Note, the same applies to the
> ansi_cprng patch set).
>
> What about something like following:
>
> ...
> memcmp
> goto free_rng;

Do you find an additional jump really acceptable at such a source code place?


> report_failure:
> <failure report>
>
> free_rng:
> <the deallocation code>

I am curious on how feedback will evolve also for the other design approach.

Regards,
Markus

\
 
 \ /
  Last update: 2017-10-22 17:51    [W:0.055 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site