lkml.org 
[lkml]   [2017]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo
From
Date
On Fri, 2017-10-20 at 22:46 +0100, Maciej W. Rozycki wrote:
> On Fri, 20 Oct 2017, Joe Perches wrote:
>
> > > > That's somewhat unpleasant code as it formats a fmt string
> > > > and the compiler can not verify fmt and args.
> > > >
> > > > Perhaps something like the below is preferable:
> > >
> > > Hmm, what problem exactly are you trying to solve with code that has
> > > worked just fine for 16 years now?
> >
> > The compiler cannot verify fmt and args.
>
> You have stated that already. Why is that a problem?

Jeeze, perhaps you don't like the word perhaps.

There is no absolute defect here.

There are unnecessary pushes to stack that are
unwound by the compiler.

Stylistically, format/argument mismatches can
cause errors. It's
generally bad form and error
prone to use non constant strings as
formats.

Note it's not signed and is a simple suggestion.
If you don't like it, don't do anything with it.

\
 
 \ /
  Last update: 2017-10-22 17:47    [W:1.854 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site