lkml.org 
[lkml]   [2017]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PCI: faraday: fix inconsistent IS_ERR and PTR_ERR
On Tue, Oct 17, 2017 at 12:07:17PM -0500, Gustavo A. R. Silva wrote:
> Fix inconsistent IS_ERR and PTR_ERR in faraday_pci_probe.
> The proper pointer to be passed as argument is p->bus_clk.
>
> This issue was detected with the help of Coccinelle.
>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Huh, I merged the identical fix posted by Wei Yongjun 5 hours earlier :)
Thanks!

> ---
> This code was tested by compilation only.
>
> drivers/pci/host/pci-ftpci100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-ftpci100.c b/drivers/pci/host/pci-ftpci100.c
> index 06d9687..fae6bd1 100644
> --- a/drivers/pci/host/pci-ftpci100.c
> +++ b/drivers/pci/host/pci-ftpci100.c
> @@ -463,7 +463,7 @@ static int faraday_pci_probe(struct platform_device *pdev)
> }
> p->bus_clk = devm_clk_get(dev, "PCICLK");
> if (IS_ERR(p->bus_clk))
> - return PTR_ERR(clk);
> + return PTR_ERR(p->bus_clk);
> ret = clk_prepare_enable(p->bus_clk);
> if (ret) {
> dev_err(dev, "could not prepare PCICLK\n");
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2017-10-22 17:47    [W:0.065 / U:1.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site