Messages in this thread | | | From | Rob Herring <> | Date | Fri, 20 Oct 2017 13:12:25 -0500 | Subject | Re: [PATCH v4] of: dynamic: fix memory leak related to properties of __of_node_dup |
| |
On Thu, Oct 19, 2017 at 8:59 PM, Lixin Wang <alan.1.wang@nokia-sbell.com> wrote: > If a node with no properties is dynamically added, then a property is > dynamically added to the node, then the property is dynamically removed, > the result will be node->properties == NULL and node->deadprops != NULL. > > Add a separate function to release the properties in both lists. > > Signed-off-by: Lixin Wang <alan.1.wang@nokia-sbell.com> > Reviewed-by: Frank Rowand <frank.rowand@sony.com> > --- > Thanks the idea from Rob Herring, that I forgot to mention at patch v3. > Thanks Frank Rowand for writing to me the example. > > v3 -> v4: > * Using the style that is more consistent with device tree > code, as suggested by Frank Rowand > > drivers/of/dynamic.c | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-)
Applied.
Rob
| |