lkml.org 
[lkml]   [2017]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [Patch v6 6/7] regmap: add SLIMBUS support
    On Fri 06 Oct 08:51 PDT 2017, srinivas.kandagatla@linaro.org wrote:

    > diff --git a/drivers/base/regmap/regmap-slimbus.c b/drivers/base/regmap/regmap-slimbus.c
    [..]
    > +static int regmap_slimbus_byte_reg_read(void *context, unsigned int reg,
    > + unsigned int *val)
    > +{
    > + struct slim_device *slim = context;
    > + struct slim_val_inf msg = {0,};
    > +
    > + msg.start_offset = reg;
    > + msg.num_bytes = 1;
    > + msg.rbuf = (void *)val;

    Turn rbuf into a void * and you don't need this cast (think I commented
    on this on a previous patch as well).

    > +
    > + return slim_request_val_element(slim, &msg);
    > +}
    > +
    > +static int regmap_slimbus_byte_reg_write(void *context, unsigned int reg,
    > + unsigned int val)
    > +{
    > + struct slim_device *slim = context;
    > + struct slim_val_inf msg = {0,};
    > +
    > + msg.start_offset = reg;
    > + msg.num_bytes = 1;
    > + msg.wbuf = (void *)&val;

    Dito

    > +
    > + return slim_change_val_element(slim, &msg);
    > +}

    Regards,
    Bjorn

    \
     
     \ /
      Last update: 2017-10-22 17:34    [W:5.070 / U:0.896 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site