Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Tue, 3 Oct 2017 02:31:40 +0200 | Subject | Re: [PATCH] cpuidle: fix broadcast control when broadcast can not be entered |
| |
On Fri, Sep 1, 2017 at 9:44 AM, Thomas Gleixner <tglx@linutronix.de> wrote: > On Fri, 1 Sep 2017, Nicholas Piggin wrote: > >> When failing to enter broadcast timer mode for an idle state that >> requires it, a new state is selected that does not require broadcast, >> but the broadcast variable remains set. This causes >> tick_broadcast_exit to be called despite not having entered broadcast >> mode. >> >> This causes the WARN_ON_ONCE(!irqs_disabled()) to trigger in some >> cases. It does not appear to cause problems for code today, but seems >> to violate the interface so should be fixed. >> >> Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > > Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Applied, thanks!
| |