Messages in this thread | | | Date | Mon, 2 Oct 2017 15:54:25 -0400 | From | Johannes Weiner <> | Subject | Re: [PATCH] writeback: remove unused parameter from balance_dirty_pages() |
| |
On Mon, Oct 02, 2017 at 09:56:16AM +0200, Michal Hocko wrote: > On Wed 27-09-17 15:13:11, Tahsin Erdogan wrote: > > "mapping" parameter to balance_dirty_pages() is not used anymore. > > > > Fixes: dfb8ae567835 ("writeback: let balance_dirty_pages() work on the matching cgroup bdi_writeback") > > balance_dirty_pages_ratelimited doesn't really need mapping as well. All > it needs is the inode and we already have it in callers. So would it > make sense to refactor a bit further and make its argument an inode?
It's nicer to keep this a "page cache" interface, as its primary callsites are in mm/memory.c and mm/filemap.c:
$ git grep -c 'inode' mm/filemap.c mm/memory.c mm/filemap.c:38 $ git grep -c 'mapping' mm/filemap.c mm/memory.c mm/filemap.c:260 mm/memory.c:93
> > Signed-off-by: Tahsin Erdogan <tahsin@google.com> > > Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
| |