lkml.org 
[lkml]   [2017]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH RFC V4 1/6] perf tools: lock to protect namespaces and comm list
Date
> Em Fri, Sep 29, 2017 at 07:47:52AM -0700, kan.liang@intel.com escreveu:
> > From: Kan Liang <kan.liang@intel.com>
> >
> > Add two locks to protect namespaces_list and comm_list.
> >
> > The lock is only needed for multithreaded code, so using mutex
> > wrappers provided by perf tool.
> >
> > Not all the comm_list/namespaces_list accessing are protected, e.g.
> > thread__exec_comm. Because the multithread code for perf top event
> > synthesizing does not touch them. They don't need a lock.
>
> They don't need a lock _now_, ok I think we can proceed that way, this cset
> should serve as a warning to people working in further multithreading perf.
>

Do I need to add some comments in the code to give a warning?

Thanks,
Kan

\
 
 \ /
  Last update: 2017-10-02 21:15    [W:0.062 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site