lkml.org 
[lkml]   [2017]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] printk: simplify no_printk()
On Mon 2017-09-18 00:01:44, Masahiro Yamada wrote:
> Commit 069f0cd00df0 ("printk: Make the printk*once() variants return
> a value") surrounded the macro implementation with ({ ... }).
>
> Now, the inner do { ... } while (0); is redundant.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Looks fine to me. The return value is slightly more visible now ;-)

Reviewed-by: Petr Mladek <pmladek@suse.com>

JFYI, I have pushed it into for-4.15 branch.

Best Regards,
Petr

\
 
 \ /
  Last update: 2017-10-02 16:57    [W:0.071 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site