Messages in this thread | | | Date | Mon, 2 Oct 2017 16:56:27 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH] printk: simplify no_printk() |
| |
On Mon 2017-09-18 00:01:44, Masahiro Yamada wrote: > Commit 069f0cd00df0 ("printk: Make the printk*once() variants return > a value") surrounded the macro implementation with ({ ... }). > > Now, the inner do { ... } while (0); is redundant. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Looks fine to me. The return value is slightly more visible now ;-)
Reviewed-by: Petr Mladek <pmladek@suse.com>
JFYI, I have pushed it into for-4.15 branch.
Best Regards, Petr
| |