Messages in this thread | | | Date | Thu, 19 Oct 2017 17:10:08 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH V8 3/5] scsi: Align block queue to dma_get_cache_alignment() |
| |
On Tue, Oct 17, 2017 at 04:05:40PM +0800, Huacai Chen wrote: > In non-coherent DMA mode, kernel uses cache flushing operations to > maintain I/O coherency, so scsi's block queue should be aligned to > ARCH_DMA_MINALIGN. Otherwise, If a DMA buffer and a kernel structure > share a same cache line, and if the kernel structure has dirty data, > cache_invalidate (no writeback) will cause data corruption.
Looks fine to, and I like cleaning up the arcane 0x03 as wel.
| |