lkml.org 
[lkml]   [2017]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: kernel/module: Delete an error message for a failed memory allocation in add_module_usage()
From
Date
>>>> Omit an extra message for a memory allocation failure in this function.
>>>>
>>>> This issue was detected by using the Coccinelle software.
>>>>
>>>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>>>
>>> Applied to modules-next, thanks.
>>
>> Thanks for your acceptance of this update suggestion after a bit of clarification.
>>
>> Do you see any need that I should extend subsequent commit messages
>> for this software transformation pattern?
>
> Add a description of _why_ this is being done.
>
> Something like:
>
> "because there is a dump_stack() done on allocation failures
> without __GFP_JNOWARN"

How do you think about to convert such a description into a special format
for further reference documentation?

Regards,
Markus

\
 
 \ /
  Last update: 2017-10-22 17:23    [W:0.039 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site