Messages in this thread | | | Date | Wed, 18 Oct 2017 18:08:41 -0700 | From | Matthew Wilcox <> | Subject | Re: [PATCH] zswap: Same-filled pages handling |
| |
On Thu, Oct 19, 2017 at 12:31:18AM +0300, Timofey Titovets wrote: > > +static void zswap_fill_page(void *ptr, unsigned long value) > > +{ > > + unsigned int pos; > > + unsigned long *page; > > + > > + page = (unsigned long *)ptr; > > + if (value == 0) > > + memset(page, 0, PAGE_SIZE); > > + else { > > + for (pos = 0; pos < PAGE_SIZE / sizeof(*page); pos++) > > + page[pos] = value; > > + } > > +} > > Same here, but with memcpy().
No. Use memset_l which is optimised for this specific job.
| |