lkml.org 
[lkml]   [2017]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] char-TPM: Adjustments for ten function implementations
On Tue, Oct 17, 2017 at 08:57:13AM -0700, James Bottomley wrote:
> On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote:
> > >
> > > Fixes is only for bug fixes.  These don't fix any bugs.
> >
> > How do you distinguish these in questionable source code
> > from other error categories or software weaknesses?
>
> A style change is one that doesn't change the effect of the execution.
>  These don't actually even change the assembly, so there's programmatic
> proof they're not fixing anything.
>
> Bug means potentially user visible fault.  In any bug fix commit you
> should document the fault and its effects on users so those backporting
> can decide if they care or not.
>
> James

OK, I'll adjust my definition of a bug :-)

/Jarkko

\
 
 \ /
  Last update: 2017-10-22 17:15    [W:4.854 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site