lkml.org 
[lkml]   [2017]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 答复 : [PATCH] misc: rtsx: Move Realtek Card Reader Driver to misc
On Wed, Oct 18, 2017 at 09:21:44AM +0000, 冯锐 wrote:
> > On Wed, Oct 18, 2017 at 10:45 AM, <rui_feng@realsil.com.cn> wrote:
> > > From: rui_feng <rui_feng@realsil.com.cn>
> > >
> > > Move Realtek PCIE Card Reader Driver to misc.
> > > 1.Create a folder realtek to store rtl8411.c rts5209.c rts5227.c
> > > rts5229.c rts5249.c rtsx_pcr.c rtsx_pcr.h.
> > > 2.Move include/linux/mfd/rtsx_common.h and
> > > include/linux/mfd/rtsx_pci.h to include/linux.
> > > 3.Move all Kconfig and Makefile related to Realtek card readers to misc.
> > >
> > > Signed-off-by: rui_feng <rui_feng@realsil.com.cn>
> > > ---
> > > drivers/memstick/host/rtsx_pci_ms.c | 2 +-
> > > drivers/mfd/Kconfig | 11 -
> > > drivers/mfd/Makefile | 2 -
> > > drivers/mfd/rtl8411.c | 508 ------------
> > > drivers/mfd/rts5209.c | 277 -------
> > > drivers/mfd/rts5227.c | 374 ---------
> >
> > Please update the patch with two changes:
> >
> > 1. rewrite the changelog completely to explain *why* you do this. We can see
> > from the patch what it does, no need to go into detail about it beyond the
> > subject, but I have no idea what this is good for.
> >
> Because Realtek PCIE card reader driver is a pcie driver, and it bridges mmc subsystem and memstick subsystem, it's not a mfd driver.
> Greg and Lee Jones had a discuss about where to put the driver, the result is that misc is a good place for it, so I move all files to misc.
> If I don't move it to a right place, I can't add any patch for new chip support.

Great, explain that in the changelog description!

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-10-22 17:12    [W:0.063 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site