Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH] fat: remove redundant assignment of 0 to slots | Date | Wed, 18 Oct 2017 12:32:52 +0900 |
| |
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com> > > The variable slots is being assigned a value of zero that is never > read, slots is being updated again a few lines later. Remove this > redundant assignment. > Cleans clang warning: Value stored to 'slots' is never read > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks like good (if old gcc didn't have false positive warning).
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> --- > fs/fat/dir.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/fat/dir.c b/fs/fat/dir.c > index 81cecbe6d7cf..b833ffeee1e1 100644 > --- a/fs/fat/dir.c > +++ b/fs/fat/dir.c > @@ -291,7 +291,6 @@ static int fat_parse_long(struct inode *dir, loff_t *pos, > } > } > parse_long: > - slots = 0; > ds = (struct msdos_dir_slot *)*de; > id = ds->id; > if (!(id & 0x40))
-- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |