Messages in this thread | | | Date | Tue, 17 Oct 2017 08:16:59 +0100 | From | Javi Merino <> | Subject | Re: [PATCH 2/2] tracing, thermal: Hide cpu cooling trace events when not in use |
| |
On Fri, Oct 13, 2017 at 10:23:09AM -0400, Steven Rostedt wrote: > From: Steven Rostedt (VMware) <rostedt@goodmis.org> > > As trace events when defined create data structures and functions to > process them, defining trace events when not using them is a waste of > memory. > > The trace events thermal_power_cpu_get_power and > thermal_power_cpu_limit are only used when CONFIG_CPU_THERMAL is set. > Make those events only defined when that is set as well. > > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Javi Merino <javi.merino@kernel.org>
> --- > Index: linux-trace.git/include/trace/events/thermal.h > =================================================================== > --- linux-trace.git.orig/include/trace/events/thermal.h > +++ linux-trace.git/include/trace/events/thermal.h > @@ -90,6 +90,7 @@ TRACE_EVENT(thermal_zone_trip, > show_tzt_type(__entry->trip_type)) > ); > > +#ifdef CONFIG_CPU_THERMAL > TRACE_EVENT(thermal_power_cpu_get_power, > TP_PROTO(const struct cpumask *cpus, unsigned long freq, u32 *load, > size_t load_len, u32 dynamic_power, u32 static_power), > @@ -147,6 +148,7 @@ TRACE_EVENT(thermal_power_cpu_limit, > __get_bitmask(cpumask), __entry->freq, __entry->cdev_state, > __entry->power) > ); > +#endif /* CONFIG_CPU_THERMAL */ > > #ifdef CONFIG_DEVFREQ_THERMAL > TRACE_EVENT(thermal_power_devfreq_get_power,
| |