Messages in this thread | | | Date | Tue, 17 Oct 2017 14:50:38 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 5/9] drm/panel: simple: add support for EDT ET0350 3.5" QVGA panel |
| |
On Wed, Oct 11, 2017 at 01:23:37PM +0200, Lothar Waßmann wrote: > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de> > --- > .../bindings/display/panel/edt,et0350g0dh6.txt | 7 +++++++
Please split bindings to separate patch.
> drivers/gpu/drm/panel/panel-simple.c | 19 +++++++++++++++++++ > 2 files changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt b/Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt > new file mode 100644 > index 0000000..5546221 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt > @@ -0,0 +1,7 @@ > +Emerging Display Technology Corp. 3.5" QVGA (320x240) TFT LCD panel > + > +Required properties: > +- compatible: should be "edt,et0350g0dh6" > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory.
No reset lines, power supplies, etc.? Yes, simple-panel.txt defines properties, but you still need to specify which ones you use. Otherwise, I don't know if this panel has a single supply or you just forgot to define the supplies.
Rob
| |