lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 12/12] PM / core: Add AVOID_RPM driver flag
From
Date
On Tue, 2017-10-17 at 17:59 +0200, Rafael J. Wysocki wrote:
> On Tuesday, October 17, 2017 5:33:17 PM CEST Andy Shevchenko wrote:
> > On Mon, 2017-10-16 at 03:32 +0200, Rafael J. Wysocki wrote:

> > > If DPM_FLAG_SMART_SUSPEND is not set, DPM_FLAG_AVOID_RPM has no
> > > effect.
> > >
> > > + if (dev_pm_test_driver_flags(dev, DPM_FLAG_SMART_SUSPEND)
> > > &&
> > > + dev_pm_test_driver_flags(dev, DPM_FLAG_AVOID_RPM)) {
> >
> > Wasn't interface designed to allow something like:
> > if (dev_pm_test_driver_flags(dev, DPM_FLAG_SMART_SUSPEND |
> > DPM_FLAG_AVOID_RPM)) {
> > instead?
>
> That would return true if any of them was set and both are needed
> here.

Ah, indeed. It would not be equivalent.

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

\
 
 \ /
  Last update: 2017-10-17 18:31    [W:0.152 / U:1.588 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site