Messages in this thread | | | Date | Tue, 17 Oct 2017 14:21:00 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH -mm] mm, pagemap: Fix soft dirty marking for PMD migration entry |
| |
On Tue, Oct 17, 2017 at 04:18:18PM +0800, Huang, Ying wrote: > From: Huang Ying <ying.huang@intel.com> > > Now, when the page table is walked in the implementation of > /proc/<pid>/pagemap, pmd_soft_dirty() is used for both the PMD huge > page map and the PMD migration entries. That is wrong, > pmd_swp_soft_dirty() should be used for the PMD migration entries > instead because the different page table entry flag is used. > > Cc: Michal Hocko <mhocko@suse.com> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Cc: David Rientjes <rientjes@google.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Hugh Dickins <hughd@google.com> > Cc: "Jérôme Glisse" <jglisse@redhat.com> > Cc: Daniel Colascione <dancol@google.com> > Cc: Zi Yan <zi.yan@cs.rutgers.edu> > Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
What is effect of the misbehaviour? pagemap reports garbage?
Shoudn't it be in stable@? And maybe add Fixes: <sha1>.
Otherwise, looks good to me.
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
-- Kirill A. Shutemov
| |