lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 19/25] thermal/drivers/hisi: Put platform code together
    On Tue, Oct 10, 2017 at 08:02:44PM +0200, Daniel Lezcano wrote:
    > From: Kevin Wangtao <kevin.wangtao@linaro.org>
    >
    > Reorganize the code for next patches by moving the functions upper in
    > the file which will prevent a forward declaration. There is no functional
    > change here.
    >


    CHECK: Please don't use multiple blank lines
    #104: FILE: drivers/thermal/hisi_thermal.c:204:

    +

    total: 0 errors, 0 warnings, 1 checks, 88 lines checked


    > Signed-off-by: Kevin Wangtao <kevin.wangtao@linaro.org>
    > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    > ---
    > drivers/thermal/hisi_thermal.c | 76 +++++++++++++++++++++---------------------
    > 1 file changed, 38 insertions(+), 38 deletions(-)
    >
    > diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
    > index befdb28..ff9055a 100644
    > --- a/drivers/thermal/hisi_thermal.c
    > +++ b/drivers/thermal/hisi_thermal.c
    > @@ -201,6 +201,44 @@ static void hisi_thermal_disable_sensor(struct hisi_thermal_data *data)
    > clk_disable_unprepare(data->clk);
    > }
    >
    > +
    > +static int hisi_thermal_setup(struct hisi_thermal_data *data)
    > +{
    > + struct hisi_thermal_sensor *sensor = &data->sensor;
    > + int ret;
    > +
    > + /* enable clock for tsensor */
    > + ret = clk_prepare_enable(data->clk);
    > + if (ret)
    > + return ret;
    > +
    > + /* disable module firstly */
    > + hisi_thermal_reset_enable(data->regs, 0);
    > + hisi_thermal_enable(data->regs, 0);
    > +
    > + /* select sensor id */
    > + hisi_thermal_sensor_select(data->regs, sensor->id);
    > +
    > + /* setting the hdak time */
    > + hisi_thermal_hdak_set(data->regs, 0);
    > +
    > + /* setting lag value between current temp and the threshold */
    > + hisi_thermal_set_lag(data->regs, HISI_TEMP_LAG);
    > +
    > + /* enable for interrupt */
    > + hisi_thermal_alarm_set(data->regs, sensor->thres_temp);
    > +
    > + hisi_thermal_reset_set(data->regs, HISI_TEMP_RESET);
    > +
    > + /* enable module */
    > + hisi_thermal_reset_enable(data->regs, 1);
    > + hisi_thermal_enable(data->regs, 1);
    > +
    > + hisi_thermal_alarm_clear(data->regs, 0);
    > + hisi_thermal_alarm_enable(data->regs, 1);
    > +
    > + return 0;
    > +}
    > static int hisi_thermal_get_temp(void *__data, int *temp)
    > {
    > struct hisi_thermal_data *data = __data;
    > @@ -291,44 +329,6 @@ static void hisi_thermal_toggle_sensor(struct hisi_thermal_sensor *sensor,
    > on ? THERMAL_DEVICE_ENABLED : THERMAL_DEVICE_DISABLED);
    > }
    >
    > -static int hisi_thermal_setup(struct hisi_thermal_data *data)
    > -{
    > - struct hisi_thermal_sensor *sensor = &data->sensor;
    > - int ret;
    > -
    > - /* enable clock for tsensor */
    > - ret = clk_prepare_enable(data->clk);
    > - if (ret)
    > - return ret;
    > -
    > - /* disable module firstly */
    > - hisi_thermal_reset_enable(data->regs, 0);
    > - hisi_thermal_enable(data->regs, 0);
    > -
    > - /* select sensor id */
    > - hisi_thermal_sensor_select(data->regs, sensor->id);
    > -
    > - /* setting the hdak time */
    > - hisi_thermal_hdak_set(data->regs, 0);
    > -
    > - /* setting lag value between current temp and the threshold */
    > - hisi_thermal_set_lag(data->regs, HISI_TEMP_LAG);
    > -
    > - /* enable for interrupt */
    > - hisi_thermal_alarm_set(data->regs, sensor->thres_temp);
    > -
    > - hisi_thermal_reset_set(data->regs, HISI_TEMP_RESET);
    > -
    > - /* enable module */
    > - hisi_thermal_reset_enable(data->regs, 1);
    > - hisi_thermal_enable(data->regs, 1);
    > -
    > - hisi_thermal_alarm_clear(data->regs, 0);
    > - hisi_thermal_alarm_enable(data->regs, 1);
    > -
    > - return 0;
    > -}
    > -
    > static int hisi_thermal_probe(struct platform_device *pdev)
    > {
    > struct hisi_thermal_data *data;
    > --
    > 2.7.4
    >

    \
     
     \ /
      Last update: 2017-10-17 06:37    [W:5.785 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site