lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging/comedi: Convert timers to use timer_setup()
From
Date
On 17/10/17 00:25, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer
> to all timer callbacks, switch to using the new timer_setup() and
> from_timer() to pass the timer pointer explicitly. Adds pointer back to
> comedi device from private struct.
>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: devel@driverdev.osuosl.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> drivers/staging/comedi/drivers/comedi_test.c | 18 ++++++++++--------
> drivers/staging/comedi/drivers/das16.c | 11 ++++++-----
> drivers/staging/comedi/drivers/jr3_pci.c | 10 ++++++----
> 3 files changed, 22 insertions(+), 17 deletions(-)

It looks fine to me.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-

\
 
 \ /
  Last update: 2017-10-17 11:29    [W:0.030 / U:3.040 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site