Messages in this thread | | | Date | Wed, 18 Oct 2017 13:36:07 +1100 | From | "Tobin C. Harding" <> | Subject | Re: [PATCH v2] staging: ccree: fix boolreturn.cocci warning |
| |
On Wed, Oct 18, 2017 at 07:42:53AM +0530, sunil.m@techveda.org wrote: > From: Suniel Mahesh <sunil.m@techveda.org> > > Return "false" instead of 0. > > This fixes the following coccinelle warning: > WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
So close! The order of problem description and fix is inverted. What about
``` coccinelle emits: WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
Return "false" instead of 0. ```
Good luck, Tobin.
| |