lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 5/5] of/fdt: only store the device node basename in full_name
    From
    Date
    On 10/17/17 14:46, Rob Herring wrote:
    > On Tue, Oct 17, 2017 at 4:32 PM, Alan Tull <atull@kernel.org> wrote:
    >> On Mon, Aug 21, 2017 at 10:16 AM, Rob Herring <robh@kernel.org> wrote:
    >>
    >> Hi Rob,
    >>
    >>> With dependencies on a statically allocated full path name converted to
    >>> use %pOF format specifier, we can store just the basename of node, and
    >>> the unflattening of the FDT can be simplified.
    >>>
    >>> This commit will affect the remaining users of full_name. After
    >>> analyzing these users, the remaining cases should only change some print
    >>> messages. The main users of full_name are providing a name for struct
    >>> resource. The resource names shouldn't be important other than providing
    >>> /proc/iomem names.
    >>>
    >>> We no longer distinguish between pre and post 0x10 dtb formats as either
    >>> a full path or basename will work. However, less than 0x10 formats have
    >>> been broken since the conversion to use libfdt (and no one has cared).
    >>> The conversion of the unflattening code to be non-recursive also broke
    >>> pre 0x10 formats as the populate_node function would return 0 in that
    >>> case.
    >>>
    >>> Signed-off-by: Rob Herring <robh@kernel.org>
    >>> ---
    >>> v2:
    >>> - rebase to linux-next
    >>>
    >>> drivers/of/fdt.c | 69 +++++++++-----------------------------------------------
    >>> 1 file changed, 11 insertions(+), 58 deletions(-)
    >>
    >> I've just updated to the latest next branch and am finding problems
    >> applying overlays. Reverting this commit alleviates things. The
    >> errors I get are:
    >>
    >> [ 88.498704] OF: overlay: Failed to apply prop @/__symbols__/clk_0
    >> [ 88.513447] OF: overlay: apply failed '/__symbols__'
    >> [ 88.518423] create_overlay: Failed to create overlay (err=-12)
    >
    > Frank's series with overlay updates should fix this.

    Yes, it does:

    [PATCH v3 11/12] of: overlay: remove a dependency on device node full_name

    -Frank

    \
     
     \ /
      Last update: 2017-10-22 17:06    [W:3.180 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site