Messages in this thread | | | From | "Dilger, Andreas" <> | Subject | Re: [PATCH 16/20] staging: lustre: lprocfs: mark expected switch fall-throughs | Date | Tue, 17 Oct 2017 23:00:26 +0000 |
| |
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva <garsilva@embeddedor.com> wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1271166 > Addresses-Coverity-ID: 1271167 > Addresses-Coverity-ID: 1271168 > Addresses-Coverity-ID: 1271169 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> --- > drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c > index e79485b..4ec582f 100644 > --- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c > +++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c > @@ -1507,12 +1507,16 @@ int lprocfs_write_frac_u64_helper(const char __user *buffer, > switch (tolower(*end)) { > case 'p': > units <<= 10; > + /* fall through */ > case 't': > units <<= 10; > + /* fall through */ > case 'g': > units <<= 10; > + /* fall through */ > case 'm': > units <<= 10; > + /* fall through */ > case 'k': > units <<= 10; > } > -- > 2.7.4 >
Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation
| |