Messages in this thread | | | Subject | Re: [Part1 PATCH v6 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support | From | Brijesh Singh <> | Date | Mon, 16 Oct 2017 12:46:20 -0500 |
| |
On 10/16/17 11:21 AM, Borislav Petkov wrote:
...
>> +static bool sev_enabled __section(.data) = false; > You need to run a patch through checkpatch everytime you change it - > sometimes the warning makes sense, like in this case: > > ERROR: do not initialise statics to false > #73: FILE: arch/x86/mm/mem_encrypt.c:45: > +static bool sev_enabled __section(.data) = false;
sev_enabled lives in .data section and looking at the objdump it seems to initialized to zero. So, I think its safe to remove the initialization.
Tom,
Please let me know if you are okay with the changes.
I will do a quick test run and update the patch.
| |