lkml.org 
[lkml]   [2017]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Part1 PATCH v6 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support
    From
    Date

    On 10/16/17 11:21 AM, Borislav Petkov wrote:

    ...

    >> +static bool sev_enabled __section(.data) = false;
    > You need to run a patch through checkpatch everytime you change it -
    > sometimes the warning makes sense, like in this case:
    >
    > ERROR: do not initialise statics to false
    > #73: FILE: arch/x86/mm/mem_encrypt.c:45:
    > +static bool sev_enabled __section(.data) = false;


    sev_enabled lives in .data section and looking at the objdump it seems
    to initialized to zero. So, I think its safe to remove the initialization.

    Tom,

    Please let me know if you are okay with the changes.

    I will do a quick test run and update the patch.


    \
     
     \ /
      Last update: 2017-10-16 19:47    [W:3.759 / U:0.448 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site