Messages in this thread | | | Subject | Re: [PATCH 0/2] fix lockdep warnings in s5p_mfc and exynos-gsc vb2 drivers | From | Shuah Khan <> | Date | Mon, 16 Oct 2017 08:51:20 -0600 |
| |
Hi Marek,
On 10/16/2017 06:48 AM, Marek Szyprowski wrote: > Hi Shuah, > > On 2017-10-14 01:13, Shuah Khan wrote: >> Driver mmap functions shouldn't hold lock when calling vb2_mmap(). The >> vb2_mmap() function has its own lock that it uses to protect the critical >> section. >> >> Reference: commit log for f035eb4e976ef5a059e30bc91cfd310ff030a7d3 > > It would make sense to add the information about the reference commit to each > commit message and also point to commit e752577ed7bf55c81e10343fced8b378cda2b63b, > as it is exactly the same case here. Anyway:
I think It does make sense to add the commit information to each commit message. I can do that send v2.
> > Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Thanks.
> > I wonder if makes sense to send those patches also to stable@vget.kernel.org > (maybe v4.3+, like the mentioned above commit, if they really apply?).
I don't believe they will apply as is. I can work back-porting once these get into the mainline.
> >> Shuah Khan (2): >> media: exynos-gsc: fix lockdep warning >> media: s5p-mfc: fix lockdep warning >> >> drivers/media/platform/exynos-gsc/gsc-m2m.c | 5 ----- >> drivers/media/platform/s5p-mfc/s5p_mfc.c | 3 --- >> 2 files changed, 8 deletions(-) >> > > Best regards
thanks, -- Shuah
| |