lkml.org 
[lkml]   [2017]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RESEND PATCH v2 4/5] drm/bridge/analogix: Do not use device's drvdata
    From
    Date
    On 16.10.2017 12:06, Jeffy Chen wrote:
    > From: Tomasz Figa <tfiga@chromium.org>
    >
    > The driver that instantiates the bridge should own the drvdata, as all
    > driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also
    > owned by its driver struct. Moreover, storing two different pointer
    > types in driver data depending on driver initialization status is barely
    > a good practice and in fact has led to many bugs in this driver.
    >
    > Let's clean up this mess and change Analogix entry points to simply
    > accept some opaque struct pointer, adjusting their users at the same
    > time to avoid breaking the compilation.
    >
    > Signed-off-by: Tomasz Figa <tfiga@chromium.org>
    > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>

    Thanks for making it a bit saner.

    Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

     --
    Regards
    Andrzej

    \
     
     \ /
      Last update: 2017-10-16 12:44    [W:3.319 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site