lkml.org 
[lkml]   [2017]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] dt-bindings: add binding for Allwinner R40 SATA AHCI controller
On Sun, Oct 08, 2017 at 12:35:40PM +0800, Icenowy Zheng wrote:
> The Allwinner R40 SoC contains a SATA AHCI controller like the one in
> A10/A20 SoCs, however a reset control and two power supplies are added
> to it.
>
> Add a binding document for it.
>
> As a dedicated binding document is needed now for the A10/A20/R40 AHCI
> controller, drop the A10 compatible line from generic platform AHCI
> controller binding document.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> .../devicetree/bindings/ata/ahci-platform.txt | 1 -
> .../bindings/ata/allwinner,sun4i-a10-ahci.txt | 40 ++++++++++++++++++++++
> 2 files changed, 40 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.txt
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> index fedc213b5f1a..da6818b2c204 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> @@ -9,7 +9,6 @@ PHYs.
>
> Required properties:
> - compatible : compatible string, one of:
> - - "allwinner,sun4i-a10-ahci"
> - "brcm,iproc-ahci"
> - "hisilicon,hisi-ahci"
> - "cavium,octeon-7130-ahci"
> diff --git a/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.txt b/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.txt
> new file mode 100644
> index 000000000000..0eea78c14ad3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.txt
> @@ -0,0 +1,40 @@
> +Allwinner A10/A20/R40 SoC SATA AHCI Controller
> +
> +Required properties:
> +- compatible : compatible string, one of:
> + - "allwinner,sun4i-a10-ahci"
> + - "allwinner,sun8i-r40-ahci"
> +- interrupts : the SATA IRQ
> +- reg : the register mapping
> +- clocks : the clocks needed by SATA controller, usually contains
> + an AHB clock and a mod clock
> +
> +Optional properties:
> +- target-supply : regulator for SATA target power
> +
> +Required properties for the following compatibles:
> + - "allwinner,sun8i-r40-ahci"
> +- resets : the reset control needed by SATA controller
> +- vdd1v2-supply : regulator for SATA controller's 1.2V VDD
> +- vdd2v5-supply : regulator for SATA controller's 2.5V VDD

I have to wonder, are these really for the controller and not the phy?
You don't have any phy?

Rob

\
 
 \ /
  Last update: 2017-10-13 21:43    [W:0.264 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site