lkml.org 
[lkml]   [2017]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] bcache: safeguard a dangerous addressing in closure_queue
From
Date
Hi Liang--

Thanks for the quick turnaround. I've added this to bcache-for-next.

On 10/12/2017 10:30 PM, Liang Chen wrote:
> The use of the union reduces the size of closure struct by taking advantage
> of the current size of its members. The offset of func in work_struct equals
> the size of the first three members, so that work.work_func will just
> reference the forth member - fn.
>
> This is smart but dangerous. It can be broken if work_struct or the other
> structs get changed, and can be a bit difficult to debug.
>
> Signed-off-by: Liang Chen <liangchen.linux@gmail.com>

Reviewed-by: Michael Lyle <mlyle@lyle.org>

-Mike

\
 
 \ /
  Last update: 2017-10-13 07:49    [W:0.030 / U:3.228 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site