lkml.org 
[lkml]   [2017]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cklight: tps65217_bl: Remove unnecessary default brightness check
On Sun, 08 Oct 2017, Christos Gkekas wrote:

> Variable val holds the default brightness and is unsigned, therefore
> checking whether it is less than zero is redundant.
>
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
> ---
> drivers/video/backlight/tps65217_bl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Subject line fixed and patch applied, thanks.

> diff --git a/drivers/video/backlight/tps65217_bl.c b/drivers/video/backlight/tps65217_bl.c
> index fd524ad..61ea82d 100644
> --- a/drivers/video/backlight/tps65217_bl.c
> +++ b/drivers/video/backlight/tps65217_bl.c
> @@ -239,8 +239,7 @@ tps65217_bl_parse_dt(struct platform_device *pdev)
> }
>
> if (!of_property_read_u32(node, "default-brightness", &val)) {
> - if (val < 0 ||
> - val > 100) {
> + if (val > 100) {
> dev_err(&pdev->dev,
> "invalid 'default-brightness' value in the device tree\n");
> err = ERR_PTR(-EINVAL);

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2017-10-13 10:50    [W:0.042 / U:0.324 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site