Messages in this thread Patch in this message | | | From | Kamalesh Babulal <> | Subject | [PATCH] objtool: Fix memory leak in decode_instructions() | Date | Thu, 12 Oct 2017 14:32:14 +0530 |
| |
free the allocated insn before returning, when an error occurs before adding insn to file->insn_list.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> --- tools/objtool/check.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c index a0c518ecf085..c0e26ad1fa7e 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -267,12 +267,13 @@ static int decode_instructions(struct objtool_file *file) &insn->immediate, &insn->stack_op); if (ret) - return ret; + goto err; if (!insn->type || insn->type > INSN_LAST) { WARN_FUNC("invalid instruction type %d", insn->sec, insn->offset, insn->type); - return -1; + ret = -1; + goto err; } hash_add(file->insn_hash, &insn->hash, insn->offset); @@ -296,6 +297,10 @@ static int decode_instructions(struct objtool_file *file) } return 0; + +err: + free(insn); + return ret; } /* -- 2.11.0
| |