Messages in this thread | | | Date | Thu, 12 Oct 2017 11:30:17 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v2 1/5] bitops: Introduce assign_bit() |
| |
On Thu, 12 Oct 2017 12:40:10 +0200 Lukas Wunner <lukas@wunner.de> wrote:
> A common idiom is to assign a value to a bit with: > > if (value) > set_bit(nr, addr); > else > clear_bit(nr, addr); > > Likewise common is the one-line expression variant: > > value ? set_bit(nr, addr) : clear_bit(nr, addr); > > Commit 9a8ac3ae682e ("dm mpath: cleanup QUEUE_IF_NO_PATH bit > manipulation by introducing assign_bit()") introduced assign_bit() > to the md subsystem for brevity. > > Make it available to others, specifically gpiolib and the upcoming > driver for Maxim MAX3191x industrial serializer chips. > > As requested by Peter Zijlstra, change the argument order to reflect > traditional "dst = src" in C, hence "assign_bit(nr, addr, value)".
Acked-by: Andrew Morton <akpm@linux-foundation.org>
| |