[lkml]   [2017]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RESEND PATCH v2 2/2] lockdep: Remove unnecessary acquisitions wrt workqueue flush

On Thu, Oct 12, 2017 at 04:54:35PM +0900, Byungchul Park wrote:
> On Tue, Oct 10, 2017 at 03:51:37PM +0900, Byungchul Park wrote:
> > The workqueue added manual acquisitions to catch deadlock cases.
> > Now crossrelease was introduced, some of those are redundant, since
> > wait_for_completion() already includes the acquisition for itself.
> > Removed it.
> I think manual annotations for wait_for_completion() should be removed
> in this way, since it's already embedded in wait_for_completion(), now.
> Don't you think so?

As long as we have the same level of protection, simpler code is of
course preferable. That said, I haven't followed the discussion
closely and don't want to apply it without Peter's ack. Peter?



 \ /
  Last update: 2017-10-12 17:38    [W:0.043 / U:8.456 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site