lkml.org 
[lkml]   [2017]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] mm/mempolicy.c: Fix get_nodes() off-by-one error.
On Thu, Oct 12, 2017 at 10:46:33AM +0200, Michal Hocko wrote:
> [CC Christoph who seems to be the author of the code]

Actually you can blame me. I did the mistake originally.
It was found many years ago, but then it was already too late
to change.

> Andi has voiced a concern about backward compatibility but I am not sure
> the risk is very high. The current behavior is simply broken unless you
> use a large maxnode anyway. What kind of breakage would you envision
> Andi?

libnuma uses the available number of nodes as max.

So it would always lose the last one with your chance.

Your change would be catastrophic.

The only way to fix it really would be to define
a new syscall. But I don't think it is needed,
the existing maxnode+1 interface works
(just should be properly documented)

-Andi

\
 
 \ /
  Last update: 2017-10-12 17:29    [W:0.051 / U:2.000 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site