lkml.org 
[lkml]   [2017]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/8] mm, truncate: Do not check mapping for every page being truncated
On Thu, Oct 12, 2017 at 02:15:27PM +0200, Jan Kara wrote:
> > diff --git a/mm/workingset.c b/mm/workingset.c
> > index 7119cd745ace..a80d52387734 100644
> > --- a/mm/workingset.c
> > +++ b/mm/workingset.c
> > @@ -341,12 +341,6 @@ static struct list_lru shadow_nodes;
> >
> > void workingset_update_node(struct radix_tree_node *node, void *private)
> > {
> > - struct address_space *mapping = private;
> > -
> > - /* Only regular page cache has shadow entries */
> > - if (dax_mapping(mapping) || shmem_mapping(mapping))
> > - return;
> > -
>
> Hum, we don't need to pass 'mapping' from call sites then? Either pass NULL
> or just remove the argument completely since nobody needs it anymore...
> Otherwise the patch looks good.
>

You're right. Initially, I was preserving the signature as it's defined
by radix_tree_update_node_t but the only user is workingset_update_node
so it can be changed.

--
Mel Gorman
SUSE Labs

\
 
 \ /
  Last update: 2017-10-12 14:41    [W:0.081 / U:0.360 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site